Harden cleanup scheduler and audit cleanup deletions

tests/test_scheduler.py

@@ -11,6 +11,7 @@ from fastapi.testclient import TestClient
 
 import karldns.app as app_module
 from karldns import DdnsSettings, DdnsStore, make_app
+from karldns.event_statuses import CLEANUP_PENDING_HOSTNAME_DELETED, CLEANUP_UNUSED_HOSTNAME_DELETED
 from karldns.security import hash_lookup_token
 
 
@@ -174,6 +175,9 @@ def test_cleanup_removes_pending_generated_setups_after_cutoff(tmp_path: Path) -
 
     assert result["unused_accounts"] == 1
     assert store.get_account_by_slug(account["update_slug"]) is None
+    cleanup_events = store.list_update_events_for_hostname(account["hostname"])
+    assert cleanup_events[0]["status"] == CLEANUP_PENDING_HOSTNAME_DELETED
+    assert cleanup_events[0]["detail"] == "cleanup deleted abandoned hostname"
 
 
 def test_cleanup_keeps_recent_pending_setup_until_pending_cutoff(tmp_path: Path) -> None:
@@ -194,6 +198,26 @@ def test_cleanup_keeps_recent_pending_setup_until_pending_cutoff(tmp_path: Path)
     assert store.get_account_by_slug(account["update_slug"]) is not None
 
 
+def test_cleanup_logs_event_for_accepted_unused_hostname(tmp_path: Path) -> None:
+    database_path = tmp_path / "ddns.sqlite3"
+    store = DdnsStore(database_path)
+    account = store.create_account("unused.ddns.example.net", "router", accepted=True)
+
+    with store.connect() as conn:
+        conn.execute(
+            "UPDATE accounts SET created_at = ? WHERE hostname = ?",
+            ("2000-01-01T00:00:00+00:00", account["hostname"]),
+        )
+
+    result = store.cleanup(unused_account_hours=1)
+
+    assert result["unused_accounts"] == 1
+    assert store.get_account_by_slug(account["update_slug"]) is None
+    cleanup_events = store.list_update_events_for_hostname(account["hostname"])
+    assert cleanup_events[0]["status"] == CLEANUP_UNUSED_HOSTNAME_DELETED
+    assert cleanup_events[0]["detail"] == "cleanup deleted abandoned hostname"
+
+
 def test_pending_generated_setup_stays_pending_after_restart(tmp_path: Path) -> None:
     database_path = tmp_path / "ddns.sqlite3"
     store = DdnsStore(database_path)
@@ -389,3 +413,29 @@ def test_scheduled_cleanup_failure_is_logged(tmp_path: Path, monkeypatch, caplog
     assert scheduled_task["last_status"] == "error"
     assert "RuntimeError: cleanup exploded" in str(scheduled_task["last_error"])
     assert "Scheduled cleanup failed" in caplog.text
+
+
+def test_scheduler_loop_survives_iteration_exception(tmp_path: Path, monkeypatch, caplog) -> None:
+    settings = DdnsSettings(database_path=tmp_path / "ddns.sqlite3", admin_password="admin", cleanup_interval_seconds=60)
+    store = DdnsStore(settings.database_path)
+    calls = 0
+
+    async def fail_once_then_cancel(inner_store, inner_settings):
+        nonlocal calls
+        calls += 1
+        if calls == 1:
+            raise RuntimeError("post-cleanup crash")
+        raise asyncio.CancelledError
+
+    async def no_sleep(_seconds: float) -> None:
+        return None
+
+    caplog.set_level(logging.ERROR, logger="karldns.app")
+    monkeypatch.setattr(app_module, "_run_cleanup_if_due", fail_once_then_cancel)
+    monkeypatch.setattr(app_module.asyncio, "sleep", no_sleep)
+
+    with pytest.raises(asyncio.CancelledError):
+        asyncio.run(app_module._scheduler_loop(store, settings))
+
+    assert calls == 2
+    assert "Scheduled cleanup loop crashed; continuing" in caplog.text